Use singular for property names in output metadata#150
Merged
Luthaf merged 2 commits intometatensor:mainfrom Feb 2, 2026
Merged
Use singular for property names in output metadata#150Luthaf merged 2 commits intometatensor:mainfrom
Luthaf merged 2 commits intometatensor:mainfrom
Conversation
Luthaf
force-pushed
the
plural-properties
branch
from
4fa8195 to
50a1b18
Compare
Co-authored-by: Rohit Goswami <r95g10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we are using a mix of singular/plural here, with no reason.
We are still using a mix of singular (energy) and plural (charges, nc_forces, …) for the output names, but this would be a lot harder to fix in a backward compatible way, so let's think about this and decide what we should do later.
Contributor (creator of pull-request) checklist
Issue referenced (for PRs that solve an issue)?Reviewer checklist